Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ako/ Codecov master branch coverage #5115

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Ako/ Codecov master branch coverage #5115

merged 5 commits into from
Apr 14, 2022

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

To handle master branch coverage

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Docs label Mar 27, 2022
@vercel
Copy link

vercel bot commented Mar 27, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/9EoKqoutBowPhr6UnZtNoALBQM71
✅ Preview: https://deriv-app-git-fork-ali-hosseini-fs-codecov-release.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/5115](https://github.com/binary-com/deriv-app/pull/5115)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-fs-codecov-release.binary.sx?qa_server=frontend.binaryws.com&app_id=24073
    - **Original**: https://deriv-app-git-fork-ali-hosseini-fs-codecov-release.binary.sx
- **App ID**: `24073`

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e249037). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5115   +/-   ##
=========================================
  Coverage          ?   12.13%           
=========================================
  Files             ?     1247           
  Lines             ?    28371           
  Branches          ?     4827           
=========================================
  Hits              ?     3443           
  Misses            ?    24698           
  Partials          ?      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e249037...4094ff4. Read the comment docs.

@ali-hosseini-deriv ali-hosseini-deriv changed the title Ako/ Codecov release coverage Ako/ Codecov master branch coverage Mar 27, 2022
@carolsachdeva carolsachdeva merged commit d96d143 into binary-com:master Apr 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@matin-deriv matin-deriv matin-deriv approved these changes

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@mehrzad-fs mehrzad-fs Awaiting requested review from mehrzad-fs

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ali-hosseini-deriv @codecov-commenter @balakrishna-deriv @matin-deriv @carolsachdeva